-
Notifications
You must be signed in to change notification settings - Fork 621
[TOOL-3764] Dashboard: Add Nebula FTUX #6616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6616 +/- ##
=======================================
Coverage 54.96% 54.96%
=======================================
Files 887 887
Lines 55652 55652
Branches 3802 3798 -4
=======================================
Hits 30591 30591
Misses 24966 24966
Partials 95 95
🚀 New features to boost your workflow:
|
| const res = await fetch("https://nebula-api.thirdweb.com/chat", { | ||
| method: "POST", | ||
| headers: { | ||
| "x-secret-key": "PROJECT_SECRET_KEY", | ||
| }, | ||
| body: { | ||
| message: "Hello", | ||
| stream: false, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fetch request body is incorrectly formatted. When using the Fetch API, the body needs to be JSON-stringified and the appropriate content type header should be included:
const res = await fetch("https://nebula-api.thirdweb.com/chat", {
method: "POST",
headers: {
"x-secret-key": "PROJECT_SECRET_KEY",
"Content-Type": "application/json"
},
body: JSON.stringify({
message: "Hello",
stream: false,
})
});This correction should also be applied to the Python and cURL examples for consistency.
| const res = await fetch("https://nebula-api.thirdweb.com/chat", { | |
| method: "POST", | |
| headers: { | |
| "x-secret-key": "PROJECT_SECRET_KEY", | |
| }, | |
| body: { | |
| message: "Hello", | |
| stream: false, | |
| }, | |
| }); | |
| const res = await fetch("https://nebula-api.thirdweb.com/chat", { | |
| method: "POST", | |
| headers: { | |
| "x-secret-key": "PROJECT_SECRET_KEY", | |
| "Content-Type": "application/json" | |
| }, | |
| body: JSON.stringify({ | |
| message: "Hello", | |
| stream: false, | |
| }) | |
| }); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
a5d8226 to
0205c16
Compare
e2e1fdf to
8608348
Compare
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a new `ClientIDSection` component to streamline the display of the Client ID across various components. It also modifies the `WaitingForIntegrationCard` to utilize this new component, improving code organization and reducing redundancy.
### Detailed summary
- Added `ClientIDSection` component to display the Client ID.
- Updated `InsightFTUX` to include `ClientIDSection` instead of inline code.
- Modified `WaitingForIntegrationCard` to accept children for rendering.
- Created `NebulaFTUX` component to integrate Nebula features and display Client ID.
- Adjusted styles in various components for consistency.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
0205c16 to
737155b
Compare
8608348 to
08eea95
Compare

PR-Codex overview
This PR introduces a
ClientIDSectioncomponent to streamline the display of the client ID across various components. It also adds aNebulaFTUXcomponent for integrating Nebula and refactors theWaitingForIntegrationCardto utilize children for flexibility.Detailed summary
ClientIDSectioncomponent to display client ID.InsightFTUXto includeClientIDSection.WaitingForIntegrationCardto accept children, removing direct client ID rendering.NebulaFTUXcomponent for Nebula integration.NebulaFTUX.