Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 1, 2025


PR-Codex overview

This PR introduces a ClientIDSection component to streamline the display of the client ID across various components. It also adds a NebulaFTUX component for integrating Nebula and refactors the WaitingForIntegrationCard to utilize children for flexibility.

Detailed summary

  • Added ClientIDSection component to display client ID.
  • Updated InsightFTUX to include ClientIDSection.
  • Refactored WaitingForIntegrationCard to accept children, removing direct client ID rendering.
  • Introduced NebulaFTUX component for Nebula integration.
  • Added example code snippets for JavaScript, Python, and Curl in NebulaFTUX.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Apr 1, 2025

@vercel
Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 9:20am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 2, 2025 9:20am
login ⬜️ Skipped (Inspect) Apr 2, 2025 9:20am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 2, 2025 9:20am
wallet-ui ⬜️ Skipped (Inspect) Apr 2, 2025 9:20am

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025

⚠️ No Changeset found

Latest commit: 08eea95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login April 1, 2025 20:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 1, 2025 20:52 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 1, 2025 20:52 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 1, 2025 20:52 Inactive
@MananTank MananTank marked this pull request as ready for review April 1, 2025 20:53
@MananTank MananTank requested review from a team as code owners April 1, 2025 20:53
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 1, 2025
Copy link
Member Author

MananTank commented Apr 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.49 KB (0%) 950 ms (0%) 172 ms (+174.11% 🔺) 1.2 s
thirdweb (cjs) 129.89 KB (0%) 2.6 s (0%) 230 ms (+31.85% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 128 ms (+1249.09% 🔺) 240 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 33 ms (+1405.58% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 109 ms (+635.22% 🔺) 496 ms

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.96%. Comparing base (737155b) to head (08eea95).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6616   +/-   ##
=======================================
  Coverage   54.96%   54.96%           
=======================================
  Files         887      887           
  Lines       55652    55652           
  Branches     3802     3798    -4     
=======================================
  Hits        30591    30591           
  Misses      24966    24966           
  Partials       95       95           
Flag Coverage Δ
packages 54.96% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 1, 2025 21:53 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 1, 2025 21:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 1, 2025 21:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 1, 2025 21:53 Inactive
Comment on lines +64 to +73
const res = await fetch("https://nebula-api.thirdweb.com/chat", {
method: "POST",
headers: {
"x-secret-key": "PROJECT_SECRET_KEY",
},
body: {
message: "Hello",
stream: false,
},
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fetch request body is incorrectly formatted. When using the Fetch API, the body needs to be JSON-stringified and the appropriate content type header should be included:

const res = await fetch("https://nebula-api.thirdweb.com/chat", {
  method: "POST",
  headers: {
    "x-secret-key": "PROJECT_SECRET_KEY",
    "Content-Type": "application/json"
  },
  body: JSON.stringify({
    message: "Hello",
    stream: false,
  })
});

This correction should also be applied to the Python and cURL examples for consistency.

Suggested change
const res = await fetch("https://nebula-api.thirdweb.com/chat", {
method: "POST",
headers: {
"x-secret-key": "PROJECT_SECRET_KEY",
},
body: {
message: "Hello",
stream: false,
},
});
const res = await fetch("https://nebula-api.thirdweb.com/chat", {
method: "POST",
headers: {
"x-secret-key": "PROJECT_SECRET_KEY",
"Content-Type": "application/json"
},
body: JSON.stringify({
message: "Hello",
stream: false,
})
});

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 2, 2025 07:20 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 2, 2025 07:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 2, 2025 07:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 2, 2025 07:20 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 2, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new `ClientIDSection` component to streamline the display of the Client ID across various components. It also modifies the `WaitingForIntegrationCard` to utilize this new component, improving code organization and reducing redundancy.

### Detailed summary
- Added `ClientIDSection` component to display the Client ID.
- Updated `InsightFTUX` to include `ClientIDSection` instead of inline code.
- Modified `WaitingForIntegrationCard` to accept children for rendering.
- Created `NebulaFTUX` component to integrate Nebula features and display Client ID.
- Adjusted styles in various components for consistency.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 2, 2025 09:13 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 2, 2025 09:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 2, 2025 09:13 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 2, 2025 09:13 Inactive
Base automatically changed from tool-3765 to main April 2, 2025 09:21
@graphite-app graphite-app bot merged commit 08eea95 into main Apr 2, 2025
30 checks passed
@graphite-app graphite-app bot deleted the tool-3764 branch April 2, 2025 09:22
@vercel vercel bot temporarily deployed to Production – docs-v2 April 2, 2025 09:22 Inactive
@vercel vercel bot temporarily deployed to Production – login April 2, 2025 09:22 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 2, 2025 09:22 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 2, 2025 09:22 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants